Ticket #333 (closed defect: fixed)

Opened 9 months ago

Last modified 8 months ago

LDAP Authentication trying to re-create users

Reported by: justinr Assigned to: nobody
Priority: normal Milestone: 0.9.2
Component: core Version: 0.9.0
Severity: normal Keywords:
Cc: Patch Included: 1
Review Stage: reviewed

Description

After fixing the messages in #332, I found that the LDAP authentication plugin is erroneously trying to create new users on every login. This is easily fixed with the enclosed patch.

Attachments

ldapauth-userexists.patch (0.8 kB) - added by justinr on 03/20/08 16:50:56.
ldapauth-userexists2.patch (0.5 kB) - added by justinr on 03/26/08 17:55:37.
ldapauth-userexists.diff (0.5 kB) - added by justinr on 03/26/08 17:58:56.

Change History

03/20/08 16:50:56 changed by justinr

  • attachment ldapauth-userexists.patch added.

03/26/08 10:13:54 changed by misja

The patch doesn't work, prob. due to incorrect context. Could you regenerate it following the description in http://elgg.org/mod/mediawiki/wiki/index.php/Contributing_code ?

03/26/08 17:55:37 changed by justinr

  • attachment ldapauth-userexists2.patch added.

03/26/08 17:58:56 changed by justinr

  • attachment ldapauth-userexists.diff added.

(follow-up: ↓ 3 ) 03/26/08 18:01:05 changed by justinr

new diff off of SVN copy (we're running 0.9.1, not SVN on our instance)

(in reply to: ↑ 2 ) 03/26/08 19:07:32 changed by justinr

Replying to justinr:

new diff off of SVN copy (we're running 0.9.1, not SVN on our instance)

(Note: Take the *.diff file above, named as per the contribution instructions -- it doesn't seem to want to let me delete other files)

03/26/08 20:21:32 changed by misja

  • status changed from new to closed.
  • resolution set to fixed.

(In reply to comment #3)

(Note: Take the *.diff file above, named as per the contribution instructions -- it doesn't seem to want to let me delete other files)

The patch applies cleanly now, thanks :) Fixed in r574

03/26/08 20:22:55 changed by misja

  • review_stage changed from unreviewed to reviewed.

03/26/08 20:24:18 changed by misja

That should be r1574