Ticket #332 (closed defect: fixed)

Opened 9 months ago

Last modified 8 months ago

Missing global $messages in auth/ldap/lib.php

Reported by: justinr Assigned to: nobody
Priority: normal Milestone: 0.9.2
Component: core Version: 0.9.0
Severity: normal Keywords:
Cc: Patch Included: 0
Review Stage: reviewed

Description

Several places in auth/ldap/lib.php are missing a call to make the global variable $messages accessible to functions. This buries several important error messages.

Attachments

ldapauth-messages.patch (0.8 kB) - added by justinr on 03/20/08 16:45:47.
ldapauth-messages.diff (0.8 kB) - added by justinr on 03/26/08 17:59:37.

Change History

03/20/08 16:45:47 changed by justinr

  • attachment ldapauth-messages.patch added.

03/26/08 10:13:19 changed by misja

The patch doesn't work, prob. due to incorrect context. Could you regenerate it following the description in http://elgg.org/mod/mediawiki/wiki/index.php/Contributing_code ?

03/26/08 17:59:37 changed by justinr

  • attachment ldapauth-messages.diff added.

(follow-up: ↓ 3 ) 03/26/08 18:01:42 changed by justinr

  • milestone changed from 0.9.1 to 0.9.2.

updated new patch against SVN

(in reply to: ↑ 2 ) 03/26/08 19:08:04 changed by justinr

Replying to justinr:

updated new patch against SVN

(Note: Take the *.diff file above, named as per the contribution instructions -- it doesn't seem to want to let me delete other files)

03/26/08 20:22:38 changed by misja

  • status changed from new to closed.
  • resolution set to fixed.
  • review_stage changed from unreviewed to reviewed.

(In reply to comment #3)

(Note: Take the *.diff file above, named as per the contribution instructions -- it doesn't seem to want to let me delete other files)

The patch applies cleanly now, thanks :) Fixed in r574

03/26/08 20:23:58 changed by misja

That should be r1574