Ticket #297 (new defect)

Opened 7 months ago

Last modified 4 months ago

sub-menu design inconsistent with other menus

Reported by: janetp Assigned to: nobody
Priority: low Milestone: 0.9.3
Component: templates Version: 0.9.0
Severity: minor Keywords:
Cc: Patch Included: 1
Review Stage: reviewed

Description

div item id=sub-menu is not built like the other menus using an encapsulating div and ul/li for best css flexibility. the attached patches kind of hack in that flexibility.

the better solution would be a menu_builder() function that takes parameters and gives back template-ready html.

Attachments

templates.patch (0.6 kB) - added by janetp on 02/02/08 05:31:21.
patch for the file /lib/templates.php
default_template.patch (1.1 kB) - added by janetp on 02/02/08 05:33:26.
patch for the file /mod/template/lib/default_template.php

Change History

02/02/08 05:31:21 changed by janetp

  • attachment templates.patch added.

patch for the file /lib/templates.php

02/02/08 05:33:26 changed by janetp

  • attachment default_template.patch added.

patch for the file /mod/template/lib/default_template.php

02/02/08 22:10:01 changed by ewout

  • owner changed from nobody to ewout.
  • status changed from new to assigned.
  • review_stage changed from unreviewed to reviewed.

02/03/08 20:18:25 changed by ewout

  • milestone changed from 0.9.1 to 1.0.

These are for the most part very reasonable changes. But I am postponing committing this for the 1.0 release, so that we don't break peoples customized templates.

02/03/08 23:48:17 changed by dramirez

  • milestone changed from 1.0 to 0.9.1.

I agree with the changes.

I only suggest to add to the patch the necessary changes to CSS to make the submenu compatible with the current behaviour. Maybe something like:

#sub-menu-items ul{

display: inline; margin: 0px;

}

#sub-menu-items li{

list-style:none; list-style-position:outside; border-right: 1px solid black; display:inline; margin-left: 0px; padding-left: 3px; margin: 0px;

}

Its necessary to say that I'm not precisely a CSS wizard ;)

02/07/08 20:47:48 changed by ewout

  • milestone changed from 0.9.1 to 1.0.

I think we should not change html in bug fix releases, to not break customized templates. Is there a reason this cannot wait for 1.0?

02/22/08 00:30:49 changed by janetp

No reason to implement it now. it should definitely be reviewed for cleanliness. I'm not so sure my patch does all the right things in the right places.

also, while this is a fix for a display issue, all the menus could benefit from some code centralization.

03/13/08 11:26:31 changed by

  • milestone deleted.

Milestone 1.0 deleted

03/13/08 11:35:25 changed by misja

  • milestone set to 0.9.3.

05/13/08 16:30:39 changed by ewout

  • owner changed from ewout to nobody.
  • status changed from assigned to new.