Ticket #289 (new defect)

Opened 7 months ago

Last modified 7 months ago

Snoopy does not support proxy exceptions

Reported by: eavdmeer Assigned to: nobody
Priority: normal Milestone: 0.9.2
Component: feeds Version: 0.9.0
Severity: normal Keywords:
Cc: misja, renato, rho, dramirez, timh Patch Included: 1
Review Stage: accepted

Description

On a corporate Intranet, proxy servers are often used for connections to the outside world. However, there are also many internal websites that should not be routed through the proxy server. The Snoopy class (lib/snoopy/Snoopy.class.inc needs to be patched to allow exceptions. The patch that will do just that is included in this ticket.

Attachments

patch.snoopy (4.2 kB) - added by eavdmeer on 01/28/08 10:53:19.
Patch to add exception support for proxy server

Change History

01/28/08 10:53:19 changed by eavdmeer

  • attachment patch.snoopy added.

Patch to add exception support for proxy server

01/29/08 00:04:45 changed by ewout

  • cc set to misja, renato, rho, dramirez, timh.
  • review_stage changed from unreviewed to accepted.
  • milestone changed from 0.9.1 to 0.9.2.

This looks like an interesting patch. Snoopy is used by mod/newsclient to fetch rss feeds. I really don't know how to test this though, and would like to hear what other developers think.

The patch applies cleanly.

01/29/08 00:52:03 changed by rho

Looks ok.

Maybe should be added a global configuration options related to proxy, like: $CFG->proxy_host, $CFG->proxy_user, etc. Then on newsclient set the attributes to the snoopy object.