Ticket #281 (closed enhancement: fixed)

Opened 7 months ago

Last modified 5 months ago

Deleting a Folder in 'Your Files' should delete the folder contents

Reported by: scottuhi Assigned to: nobody
Priority: low Milestone: 0.9.2
Component: core Version: 0.9.0
Severity: normal Keywords: folder, fiiles, delete, my files
Cc: alistairy Patch Included: 1
Review Stage: tobeverified

Description

If you delete a personal folder all the contents of the folder are then moved up to the level that the deleted folder was on. It would be better if the contents were also deleted as is expected when a folder is deleted.

The probelm is that if you have a private folder then nobody can see the contents, irrespective of what the individual files have their permissions set at. If you subsequently delete that folder then the files appear at the folder level and retain their access permissions. Theis could result in private files appearing at the upper level. Aside from the fact that they clutter the filing system.

Attachments

en_GB.po (146.8 kB) - added by alistairy on 03/25/08 16:02:43.
files_actions.php (13.2 kB) - added by alistairy on 03/25/08 16:08:52.
files_actions.patch (4.2 kB) - added by alistairy on 03/25/08 19:24:23.

Change History

01/25/08 19:22:39 changed by ewout

  • priority changed from normal to low.
  • review_stage changed from unreviewed to consider.
  • milestone changed from 0.9.1 to 1.0.

This needs to be implemented with adequate feedback to the user. Maybe something like, "are you sure you want to delete folder X and its 234 files?". We need somebody who is willing to implement this.

03/13/08 11:26:31 changed by

  • milestone deleted.

Milestone 1.0 deleted

03/13/08 11:35:49 changed by misja

  • milestone set to 0.9.3.

03/25/08 16:02:43 changed by alistairy

  • attachment en_GB.po added.

03/25/08 16:08:52 changed by alistairy

  • attachment files_actions.php added.

03/25/08 16:11:38 changed by alistairy

  • status changed from new to closed.
  • haspatch set to 1.
  • resolution set to fixed.
  • review_stage changed from consider to tobeverified.

Fix attached in two files:

languages/en_GB/LC_MESSAGES/en_GB.po mod/file/lib/files_actions.php

It now displays the message: "Are you sure you want to permanently delete this folder and its X file(s) and X folder(s)?"

All files and folders as well as all files in all sub folders are now deleted.

03/25/08 16:28:20 changed by misja

  • status changed from closed to reopened.
  • resolution deleted.

Reopening the ticket. Please add the modifications as a patch. A modified .po file is not necessary since it gets automatically generated from the script.

03/25/08 16:29:02 changed by misja

  • cc set to alistairy.

03/25/08 19:24:23 changed by alistairy

  • attachment files_actions.patch added.

03/25/08 19:27:42 changed by alistairy

patch attached - generated from svn revision 1571

03/26/08 10:09:19 changed by misja

  • status changed from reopened to closed.
  • resolution set to fixed.
  • milestone changed from 0.9.3 to 0.9.2.

Thanks for the patch, keep 'm coming ;) Applied in r1572