Ticket #276 (closed defect: fixed)

Opened 11 months ago

Last modified 10 months ago

Title still appears when comment wall is not displayed.

Reported by: kevin Assigned to: renato
Priority: normal Milestone: 0.9.1
Component: core Version: 0.9.0
Severity: normal Keywords:
Cc: renato, ewout Patch Included: 1
Review Stage: readyforcheckin

Description

If the access to my comment wall is set to "LOGGED_IN", the title of the comment wall (eg. News's comment wall) still appears when I am not logged in.

The comment wall should be completely removed if the user does not have the correct access.

Attachments

title_commentwall_restrict_access.diff (1.7 kB) - added by renato on 02/03/08 01:12:45.
puts the title along with the rest of the html

Change History

(in reply to: ↑ description ) 01/22/08 07:51:42 changed by kevin

  • haspatch changed.
  • review_stage set to unreviewed.

I now understand that access controls do not apply properly to the comment wall and comments are always public. Nevertheless, if there are no comments and the user does not have the authority to add one, the title should not appear.

01/25/08 19:11:51 changed by ewout

  • owner changed from nobody to misja.
  • review_stage changed from unreviewed to accepted.
  • milestone changed from 0.9.1 to 0.9.2.

I think this plugin should be converted to a widget (which maybe put on new user's profiles by default). But this should be an easy change to make in the meanwhile.

02/03/08 01:12:45 changed by renato

  • attachment title_commentwall_restrict_access.diff added.

puts the title along with the rest of the html

02/03/08 01:18:02 changed by renato

  • status changed from new to assigned.
  • cc set to renato, ewout.
  • haspatch set to 1.
  • review_stage changed from accepted to readyforcheckin.
  • milestone changed from 0.9.2 to 0.9.1.
  • owner changed from misja to renato.

The issue is very simple, the html for the title was outside the access check. Just put it inside and voilà. The <div> for commentwall is still generated outside, so it keeps showing, but this is completely harmless.

If someone else can test, I will commit it.

I also think commentwall should be just another widget, removable by users in the same way, but that's not this ticket's problem.

02/07/08 21:02:42 changed by renato

  • status changed from assigned to closed.
  • resolution set to fixed.

Fixed in [1549].