Ticket #249 (new patch)

Opened 8 months ago

Last modified 4 months ago

non-existing user URLs do not generate 404s

Reported by: joerosa Assigned to: nobody
Priority: normal Milestone: 0.9.3
Component: core Version: 0.9.0
Severity: normal Keywords:
Cc: renato, rolando, misja, dramirez, timh Patch Included: 0
Review Stage: unreviewed

Description

If an URL mistakes an user http://elgg.domain.com/wrongxx it goes to a void user page. It doesn't creates an error404.

If the request is for a file (http://elgg.domain.com/wrong.xx) a dot something, it generates an error404.

After the first directive, it creates an error404 in both alternatives (any mismatch typing with or without a dot), however I have a ReWrite? rule at the end of .htaccess to hook a 404.

Attachments

empty_user_404.diff (399 bytes) - added by renato on 01/14/08 06:37:29.

Change History

01/02/08 13:53:44 changed by joerosa

What I meant by the first directive is (http://elgg.domain.com/first/...) in a URL. After the 'second slash' evreything is treated as an error404.

01/14/08 06:37:29 changed by renato

  • attachment empty_user_404.diff added.

01/14/08 06:38:57 changed by renato

  • type changed from defect to patch.

With the patch, page header returns 404 and redirects to main page.

01/20/08 00:22:51 changed by ewout

  • milestone changed from 0.9.1 to 1.0.

The question is, what do we want here? Should we return a 404 or redirect to the homepage? Also, this patch does not address the http://domain/nonexistenuser/files or /weblog etc. situations, which now also do not give 404 or redirects.

I think this needs more discussion. Leaving it to the 1.0 milestone for now. Suggestions welcome.

01/20/08 00:24:32 changed by ewout

  • cc set to renato, rolando, misja, dramirez, timh.
  • owner changed from misja to ewout.
  • status changed from new to assigned.
  • summary changed from wrong URL goes to an empty user to non-existing user URLs do not generate 404s.

03/13/08 11:26:31 changed by

  • milestone deleted.

Milestone 1.0 deleted

03/13/08 11:33:55 changed by misja

  • haspatch changed.
  • review_stage set to unreviewed.
  • milestone set to 0.9.3.

05/13/08 16:29:35 changed by ewout

  • owner changed from ewout to nobody.
  • status changed from assigned to new.