Ticket #245 (closed patch: fixed)

Opened 1 year ago

Last modified 8 months ago

Membership approval only results in an error message

Reported by: syamsul Assigned to: misja
Priority: high Milestone: 0.9.1
Component: core Version: 0.9.0
Severity: critical Keywords: review, accepted
Cc: renato Patch Included: 0
Review Stage: unreviewed

Description

I've set the Membership Restriction to a community I created to "Moderation: Memberships must be approved by you". I am encountering these 2 problems:

1) When I go to the "View membership requests" and I click on "Approve", I get this error message:

"An error occurred: the membership request could not be approved." and the request does not appear to be processed.

The request is processed properly however when it is Rejected instead.

2) A member seeking to join the community is already listed under the Members listing of the community page, even though he has not yet been approved.

Attachments

community_owner_approval.diff (0.6 kB) - added by renato on 01/16/08 08:24:17.
community_owner_approval2.diff (5.1 kB) - added by renato on 01/16/08 08:28:04.
this fixes also gettext issue and code tabbing

Change History

12/29/07 17:25:22 changed by syamsul

  • priority changed from normal to high.
  • severity changed from major to critical.

Update: It would appear that the "Moderation: Memberships must be approved by you." is not working in 0.9 at all.

Members immediately join communities they have applied to join, even though they have not been approved.

01/16/08 08:24:17 changed by renato

  • attachment community_owner_approval.diff added.

01/16/08 08:26:20 changed by renato

  • cc set to renato.
  • keywords set to patch,review.
  • type changed from defect to patch.

I tested it carefully with the patch above and now it seems to work fine. For some reason, the user was friended without any checks (??)

01/16/08 08:28:04 changed by renato

  • attachment community_owner_approval2.diff added.

this fixes also gettext issue and code tabbing

01/19/08 16:04:05 changed by ewout

  • keywords changed from patch,review to review, accepted.

01/20/08 00:09:59 changed by ewout

  • status changed from new to closed.
  • resolution set to fixed.

Committed in r1519.

01/31/08 20:34:04 changed by renato

  • haspatch changed.
  • review_stage set to unreviewed.

#294 marked as duplicate of this.

04/03/08 17:47:31 changed by abigailg

We are still seeing the problem mentioned in #2 above: users who request membership to restricted communities are added immediately without waiting for approval by the community owner. This is in version 0.9.1.