Ticket #178 (closed enhancement: fixed)

Opened 1 year ago

Last modified 1 year ago

Check for valid username while the user registers (with patch)

Reported by: ewout Assigned to: ewout
Priority: normal Milestone: 0.9
Component: core Version:
Severity: normal Keywords:
Cc: Patch Included:
Review Stage:

Description

This enhances the user experiences on registration (after the invite code is sent) by giving immediate feedback whether his chosen username is valid or not. The feedback is a continuously update image after the input field. To test, put this invitation manually in your database: insert into elgginvitations values (default,'testinvite','a@example.com','i1234567',1,unix_timestamp()); Then go to http://your-test-site/invite/join/i1234567 and test.

Besides aplying the patch, don't forget to upload the extra files to mod/invite/lib/

Attachments

checkusername.diff (1.6 kB) - added by ewout on 11/24/07 19:42:25.
bad.png (0.8 kB) - added by ewout on 11/24/07 19:45:45.
good.png (0.7 kB) - added by ewout on 11/24/07 19:46:00.
check_username.php (0.5 kB) - added by ewout on 11/24/07 19:46:25.

Change History

11/24/07 19:42:25 changed by ewout

  • attachment checkusername.diff added.

11/24/07 19:45:45 changed by ewout

  • attachment bad.png added.

11/24/07 19:46:00 changed by ewout

  • attachment good.png added.

11/24/07 19:46:25 changed by ewout

  • attachment check_username.php added.

11/26/07 12:54:21 changed by ewout

  • owner changed from misja to ewout.

Yes, I just reproduced it on a brand new elgg installation. To reproduce: 1. install elgg 2. do insert into elgginvitations values (default,'testinvite','a@example.com','i1234567',1,unix_timestamp()); in your DB 3. go to http://your-server/elgg/invite/join/i1234567

Notices: Notice: Undefined variable: details in /home/ewout/elgg/mod/invite/lib/invite_join_welcome.php on line 12 Notice: Trying to get property of non-object in /home/ewout/elgg/mod/invite/lib/invite_join_welcome.php on line 12 Notice: Undefined variable: sitename in /home/ewout/elgg/mod/invite/lib/invite_join_welcome.php on line 13 Notice: Undefined variable: sitename in /home/ewout/elgg/mod/invite/lib/invite_join_welcome.php on line 23

The notices are not the problem, the real bug is that sitename is never set.

11/26/07 13:00:53 changed by ewout

Ooops, made comment on the wrong ticket, this was meant for #179. Sorry about that. Anyway, forget about it, I solved it already. This ticket is still under discussion, though, what do you think, can I apply this before 0.9?

12/02/07 21:21:30 changed by ewout

  • status changed from new to closed.
  • resolution set to fixed.

checked it in in r1323