Ticket #176 (closed patch: fixed)

Opened 1 year ago

Last modified 1 year ago

translation problem in /units/groups/groups_explanation.php

Reported by: tuxjoe Assigned to: misja
Priority: low Milestone:
Component: core Version: 0.8.1
Severity: minor Keywords: translation
Cc: Patch Included:
Review Stage:

Description

This file can't be translated with gettext, because of the "{$CFG->sitename}" string. I would use the follwing: 

<?php

    global $CFG;

    $descOne = __gettext("Access controls let you control exactly who sees everything you upload to");
    $descTwo = __gettext(", including files, blog posts and profile items.");
    $descThree = __gettext("This screen lets you create new access controls. To get started, add a new access control by typing in its name below.");
    $run_result .= <<< END

    <p>$descOne {$CFG->sitename} $descTwo</p>
    <p>$descThree</p>
END;

?>

Change History

11/24/07 07:43:52 changed by renato

It's not good to break sentences in the middle (they could have other order in other languages, and also the .po file gets very confusing). It's better to use something like 

$descOnePlusTwo = sprintf(__gettext("Access controls let you control exactly who sees everything you upload to %s, including files, blog posts and profile items."),$CFG->sitename);

11/26/07 11:44:14 changed by misja

  • status changed from new to closed.
  • resolution set to fixed.

Applied rho's suggestion in r1314