Changeset 746

Timestamp:

12/07/06 17:22:32 (2 years ago)

Author:

sven

Message:

paging of comments on a post, so as not to try to render 148935739457398454674 comments at once.

Files:

• devel/htaccess-dist (modified) (1 diff)
• devel/units/weblogs/default_template.php (modified) (2 diffs)
• devel/units/weblogs/weblogs_posts_view.php (modified) (3 diffs)

devel/htaccess-dist

@@ -73 +73 @@
-RewriteRule ^([A-Za-z0-9]+)\/weblog\/rssnot\/(.+)\/?$ _weblog/rss2.php?weblog_name=$1&tag=$2&modifier=not
-RewriteRule ^[A-Za-z0-9]+\/weblog\/([0-9]+)\.html$ _weblog/view_post.php?post=$1
+RewriteRule ^[A-Za-z0-9]+\/weblog\/([0-9]+)\.html.([0-9]+)$ _weblog/view_post.php?post=$1&commentpage=$2
-
-RewriteRule ^tag\/(.+)\/?$ search/all.php?tag=$1

devel/units/weblogs/default_template.php

@@ -51 +51 @@
-        'description' => __gettext("A placeholder for weblog comments."),
-        'glossary' => array(
-
+
+
-        )
-    );
@@ -62 +63 @@
-<div id="comments"><!-- start comments div -->
-    <h4>$comments</h4>
+    <div>{{paging}}</div>
-    <ol>
-        {{comments}}
-    </ol>
+    <div>{{paging}}</div>
-</div><!-- end comments div -->
-END;

devel/units/weblogs/weblogs_posts_view.php

@@ -141 +141 @@
-            // if post exists and is visible
-            
+            //which page of comments to display (page numbers are 0-based)
+            $page = optional_param('commentpage', 0, PARAM_INT);
+            $perpage = 20; // set to 0/false to disable paging
+            $offset = $page * $perpage;
+            $thispageurl = $CFG->wwwroot . $username . "/weblog/" . $post->ident . ".html";
+            
-            if ($comments = get_records('weblog_comments','post_id',$post->ident,'posted ASC')) {
+                $numcomments = count($comments);
+                if (!empty($perpage) && $numcomments > $perpage) {
+                    $comments = array_slice($comments, $offset, $perpage);
+                    $numpages = ceil($numcomments / $perpage);
+                    $pagelinks = __gettext("Page: ");
+                    for ($i = 1; $i <= $numpages; $i++) {
+                        $pagenum = $i - 1;
+                        if ($pagenum != $page) {
+                            $pageurl = $thispageurl . (($pagenum) ? '.' . $pagenum : '');
+                            $pagelinks .= ' <a href="' . $pageurl . '">' . $i . '</a>' ;
+                        } else {
+                            $pagelinks .= ' ' . $i . ' ';
+                        }
+                        
+                    }
+                    $thispageurl .= '.' . $page;
+                }
+                
-                foreach($comments as $comment) {
-                    $commentmenu = "";
@@ -175 +199 @@
-                                                          'posted' => strftime("%A, %e %B %Y, %R %Z",$comment->posted),
-                                                          'usericon' => $comment->icon,
-CFG->wwwroot . $username . "/weblog/{$post->ident}.html
+thispageurl . "
-                                                          )
-                                                    );
@@ -182 +206 @@
-                $commentsbody = templates_draw(array(
-                                                     'context' => 'weblogcomments',
+                                                     'paging' => $pagelinks,
-                                                     'comments' => $commentsbody
-                                                     )