Changeset 287

Show
Ignore:
Timestamp:
04/15/06 10:25:05 (3 years ago)
Author:
ben
Message:

Update to standardise where name and icon details come from. These should be converted to functions rather than run() instructions later.

Files:

Legend:

Unmodified
Added
Removed
Modified
Copied
Moved
  • devel/profile/index.php

    r269 r287  
    2121$profile = new ElggProfile($profile_id);  
    2222         
    23 $title = $profile->display_name(); 
     23// $title = $profile->display_name(); 
     24$title = run("profile:display:name"); 
    2425 
    2526$body  = run("content:profile:view"); 
  • devel/units/communities/communities_edit.php

    r269 r287  
    2727            } 
    2828            $friends_username = stripslashes($info->username); 
    29             $friends_name = htmlspecialchars(stripslashes($info->name), ENT_COMPAT, 'utf-8'); 
     29            // $friends_name = htmlspecialchars(stripslashes($info->name), ENT_COMPAT, 'utf-8'); 
     30            $friends_name = htmlspecialchars(run("profile:display:name",$info->ident), ENT_COMPAT, 'utf-8'); 
     31            $info->icon = run("icons:get",$info->ident); 
    3032            $friends_menu = run("users:infobox:menu",array($info->ident)); 
    3133            $body .= <<< END 
  • devel/units/communities/communities_members.php

    r269 r287  
    2727            } 
    2828            $friends_username = stripslashes($info->username); 
    29             $friends_name = htmlspecialchars(stripslashes($info->name), ENT_COMPAT, 'utf-8'); 
     29            // $friends_name = htmlspecialchars(stripslashes($info->name), ENT_COMPAT, 'utf-8'); 
     30            $friends_name = htmlspecialchars(run("profile:display:name", $info->ident), ENT_COMPAT, 'utf-8'); 
     31            $info->icon = run("icons:get",$info->ident); 
    3032            // $friends_menu = run("users:infobox:menu",array($info->ident)); 
    3133            $body .= <<< END 
  • devel/units/communities/communities_membership_requests.php

    r269 r287  
    2424 
    2525                    $request_id = $pending_user->request_id; 
     26                     
     27                    $pending_user->name = run("profile:display:name",$pending_user->ident"); 
    2628                     
    2729                    $col1 = "<p><b>" . stripslashes($pending_user->name) . "</b></p>" . $description; 
  • devel/units/communities/communities_moderator_of.php

    r269 r287  
    2424            } 
    2525            $friends_username = stripslashes($info->username); 
    26             $friends_name = htmlspecialchars(stripslashes($info->name), ENT_COMPAT, 'utf-8'); 
     26            // $friends_name = htmlspecialchars(stripslashes($info->name), ENT_COMPAT, 'utf-8'); 
     27            $friends_name = htmlspecialchars(run("profile:display:name", $info->ident), ENT_COMPAT, 'utf-8'); 
     28            $info->icon = run("icons:get",$info->ident); 
    2729            // $friends_menu = run("users:infobox:menu",array($info->ident)); 
    2830            $body .= <<< END 
  • devel/units/communities/communities_owned.php

    r269 r287  
    88            $body = "<ul>"; 
    99            foreach($result as $row) { 
     10                    $row->name = run("profile:display:name",$row->ident); 
    1011                    $body .= "<li><a href=\"" . url . stripslashes($row->username) . "/\">" . stripslashes($row->name) . "</a></li>"; 
    1112            } 
  • devel/units/communities/community_memberships.php

    r269 r287  
    1111            $body = "<ul>"; 
    1212            foreach($result as $row) { 
     13                $row->name = run("profile:display:name",$row->ident); 
    1314                $body .= "<li><a href=\"" . url . stripslashes($row->username) . "/\">" . stripslashes($row->name) . "</a></li>"; 
    1415            } 
  • devel/units/files/function_search.php

    r269 r287  
    2121        } 
    2222        $searchline = " ff.ident IN (" . implode(", ", $searchlist) . ") "; 
    23         $folders = get_records_sql('SELECT ff.name,u.name AS userfullname,u.username,ff.ident  
     23        $folders = get_records_sql('SELECT ff.name,u.name AS userfullname,u.ident as userid,u.username,ff.ident  
    2424                                    FROM '.$CFG->prefix.'file_folders ff 
    2525                                    LEFT JOIN '.$CFG->prefix.'users u ON u.ident = ff.owner 
     
    3131            $f = $folders[$keys[0]]; 
    3232            if (!empty($f)) { 
    33                 $name = stripslashes($f->userfullname); 
     33                // $name = stripslashes($f->userfullname); 
     34                $name = run("profile:display:name",$f->userid); 
    3435            } 
    3536        } 
    3637         
    37         $run_result .= "<h2>" . sprintf(gettext("Folders owned by '%s' in category '%s'"),stripslashes($name),$parameter[1])."</h2>\n"; 
     38        $run_result .= "<h2>" . sprintf(gettext("Folders owned by '%s' in category '%s'"),$name,$parameter[1])."</h2>\n"; 
    3839        foreach($folders as $folder) { 
    3940            $run_result .= templates_draw(array( 
     
    5758        } 
    5859        $searchline = " f.ident IN (" . implode(", ", $searchlist) . ") "; 
    59         $files = get_records_sql('SELECT f.*,u.username,u.name AS userfullname  
     60        $files = get_records_sql('SELECT f.*,u.username,u.name AS userfullname,u.ident as userid  
    6061                                  FROM '.$CFG->prefix.'files f  
    6162                                  LEFT JOIN '.$CFG->prefix.'users u ON u.ident = f.owner  
     
    6869            $f = $files[$keys[0]]; 
    6970            if (!empty($f)) { 
    70                 $name = stripslashes($f->userfullname); 
     71                // $name = stripslashes($f->userfullname); 
     72                $name = run("profile:display:name",$f->userid); 
    7173                $username = stripslashes($f->username); 
    7274            } 
     
    110112        foreach($users as $key => $info) { 
    111113            $friends_userid = $info->ident; 
    112             $friends_name = htmlspecialchars(stripslashes($info->name), ENT_COMPAT, 'utf-8'); 
     114            // $friends_name = htmlspecialchars(stripslashes($info->name), ENT_COMPAT, 'utf-8'); 
     115            $friends_name = htmlspecialchars(run("profile:display:name",$info->ident), ENT_COMPAT, 'utf-8'); 
     116            $info->icon = run("icons:get",$info->ident); 
    113117            $friends_menu = run("users:infobox:menu",array($info->ident)); 
    114118            $link_keyword = urlencode($parameter[1]); 
  • devel/units/friends/friends_edit.php

    r269 r287  
    2626            } 
    2727            $friends_username = stripslashes($info->username); 
    28             $friends_name = htmlspecialchars(stripslashes($info->name), ENT_COMPAT, 'utf-8'); 
     28            // $friends_name = htmlspecialchars(stripslashes($info->name), ENT_COMPAT, 'utf-8'); 
     29            $friends_name = htmlspecialchars(run("profile:display:name", $info->ident), ENT_COMPAT, 'utf-8'); 
     30            $info->icon = run("icons:get",$info->ident); 
    2931            $friends_menu = run("users:infobox:menu",array($info->ident)); 
    3032            $body .= <<< END 
  • devel/units/friends/friends_of_edit.php

    r269 r287  
    2727            } 
    2828            $friends_username = stripslashes($info->username); 
    29             $friends_name = htmlspecialchars(stripslashes($info->name), ENT_COMPAT, 'utf-8'); 
     29            // $friends_name = htmlspecialchars(stripslashes($info->name), ENT_COMPAT, 'utf-8'); 
     30            $friends_name = htmlspecialchars(run("profile:display:name", $info->ident), ENT_COMPAT, 'utf-8'); 
     31            $info->icon = run("icons:get",$info->ident); 
    3032            $friends_menu = run("users:infobox:menu",array($info->ident)); 
    3133            $body .= <<< END 
  • devel/units/friends/user_friendship_requests.php

    r269 r287  
    1111            $title = run("profile:display:name") . " :: ". gettext("Friendship requests") .""; 
    1212             
    13             if ($pending_requests = get_records_sql('SELECT fr.ident AS request_id,u.*, i.filename  
     13            if ($pending_requests = get_records_sql('SELECT fr.ident AS request_id,u.* 
    1414                                                     FROM '.$CFG->prefix.'friends_requests fr LEFT JOIN '.$CFG->prefix.'users u ON u.ident = fr.owner 
    15                                                      LEFT JOIN '.$CFG->prefix.'icons i ON i.ident = u.icon 
    1615                                                     WHERE fr.friend = ? ORDER BY u.name ASC',array($page_owner))) { 
    1716                $body .= "<p>" . gettext("The following users would like to add you as a friend. They need your approval to do this (to change this setting, visit the 'account settings' page).") . "</p>"; 
     
    2827                    $request_id = $pending_user->request_id; 
    2928                     
     29                    $pending_user->name = run("profile:display:name", $pending_user->ident); 
     30                     
    3031                    $col1 = "<p><b>" . stripslashes($pending_user->name) . "</b></p>" . $description; 
    3132                    $col1 .= "<p>"; 
     
    3536                    $ident = $pending_user->ident; 
    3637 
     38                    $pending_user->icon = run("icons:get",$pending_user->ident); 
     39                     
    3740                    $body .= templates_draw(array( 
    3841                                                        'context' => 'adminTable', 
  • devel/units/icons/main.php

    r269 r287  
    1111        $function["icons:edit"][] = path . "units/icons/function_edit_icons.php";     
    1212        $function["icons:add"][] = path . "units/icons/function_add_icons.php"; 
     13         
     14    // Icon retrieval 
     15        $function["icons:get"][] = path . "units/icons/function_get_icon.php"; 
    1316     
    1417    // Permissions check 
  • devel/units/profile/function_display_name.php

    r269 r287  
    11<?php 
    22 
     3    // TODO: This should almost certainly be a function rather than a run() command 
     4 
     5    if (!defined('profileinit')) { 
     6        run("profile:init"); 
     7    } 
     8 
    39    global $profile_id; 
     10     
    411    $profile_id = (int) $profile_id; 
    512     
    613    global $name_cache; 
    714     
    8     if (!isset($name_cache[$profile_id]) || (time() - $name_cache[$profile_id]->created > 60)) { 
     15    if (empty($parameter)) { 
     16        $user_id = $profile_id; 
     17    } else { 
     18        $user_id = (int) $parameter; 
     19    } 
     20     
     21    if (!isset($name_cache[$user_id]) || (time() - $name_cache[$user_id]->created > 60)) { 
    922 
    10         $name_cache[$profile_id]->created = time(); 
    11         $name_cache[$profile_id]->data = get_field('users','name','ident',$profile_id); 
     23        $name_cache[$user_id]->created = time(); 
     24        $name_cache[$user_id]->data = get_field('users','name','ident',$user_id); 
    1225         
    1326    } 
    14     $run_result = $name_cache[$profile_id]->data; 
     27    $run_result = $name_cache[$user_id]->data; 
    1528     
    1629?> 
  • devel/units/profile/function_init.php

    r269 r287  
    2222         
    2323        $page_owner = $profile_id; 
     24         
     25        define('profileinit',true); 
    2426 
    2527?> 
  • devel/units/profile/function_search.php

    r269 r287  
    4545                foreach($result as $key => $info) { 
    4646                    $friends_username = stripslashes($info->username); 
    47                     $friends_name = htmlspecialchars(stripslashes($info->name), ENT_COMPAT, 'utf-8'); 
     47                    // $friends_name = htmlspecialchars(stripslashes($info->name), ENT_COMPAT, 'utf-8'); 
     48                    $friends_name = htmlspecialchars(run("profile:display:name",$info->ident), ENT_COMPAT, 'utf-8'); 
     49                    $info->icon = run("icons:get",$info->ident); 
    4850                    $friends_menu = run("users:infobox:menu",array($info->ident)); 
    4951                    $body .= <<< END 
  • devel/units/profile/profile_user_info.php

    r269 r287  
    1717$ul_username = run("users:id_to_name", $page_owner); 
    1818 
     19$info->icon = run("icons:get", $page_owner); 
     20 
    1921$icon = '<img src="'.url. $ul_username.'/icons/'.$info->icon.'/h/67/w/67" border="0" />'; // height is the important one here. 
    20 $name = stripslashes($info->name);  
     22// $name = stripslashes($info->name);  
     23$name = run("profile:display:name"); 
    2124$url = url . stripslashes($info->username) . "/"; 
    2225 
  • devel/units/users/user_info.php

    r269 r287  
    4747            } 
    4848             
    49             $username = htmlspecialchars(stripslashes($info->name), ENT_COMPAT, 'utf-8'); 
     49            // $username = htmlspecialchars(stripslashes($info->name), ENT_COMPAT, 'utf-8'); 
     50            $username = htmlspecialchars(run("profile:display:name",$info->ident), ENT_COMPAT, 'utf-8'); 
    5051            $usermenu = ''; 
    5152            if ($info->ident == $profile_id || (logged_on && (!isset($profile_id) && $info->ident == $_SESSION['userid']))) { 
  • devel/units/weblogs/function_search.php

    r269 r287  
    2626            } 
    2727            $searchline = " wp.ident in (" . $searchline . ")"; 
    28             if (!$posts = get_records_sql('SELECT wp.ident,u.name,u.username,wp.title,wp.ident,wp.weblog,wp.owner,wp.posted 
     28            if (!$posts = get_records_sql('SELECT wp.ident,u.name,u.username,u.ident as uesrid,wp.title,wp.ident,wp.weblog,wp.owner,wp.posted 
    2929                                     FROM '.$CFG->prefix.'weblog_posts wp JOIN '.$CFG->prefix.'users u ON u.ident = wp.owner 
    3030                                     WHERE ('.$searchline.') ORDER BY posted DESC')) { 
     
    3838                $p = $posts[$keys[0]]; 
    3939                if (!empty($p)) { 
    40                     $name = stripslashes($p->name); 
     40                    // $name = stripslashes($p->name); 
     41                    $name = run("profile:display:name",$p->userid); 
    4142                    $username = stripslashes($p->username); 
    4243                } 
     
    7980        foreach($users as $key => $info) { 
    8081            $friends_userid = $info->ident; 
    81             $friends_name = htmlspecialchars(stripslashes($info->name), ENT_COMPAT, 'utf-8'); 
     82            // $friends_name = htmlspecialchars(stripslashes($info->name), ENT_COMPAT, 'utf-8'); 
     83            $friends_name = htmlspecialchars(run("profile:display:name",$info->ident), ENT_COMPAT, 'utf-8'); 
     84            $info->icon = run("icons:get",$info->ident); 
    8285            $friends_menu = run("users:infobox:menu",array($info->ident)); 
    8386            $link_keyword = urlencode($parameter[1]); 
  • devel/units/weblogs/weblogs_posts_view.php

    r283 r287  
    1010    $url = url; 
    1111     
    12     if (!isset($post_authors[$post->owner])) { 
     12    //if (!isset($post_authors[$post->owner])) { 
    1313         
    1414        $author = ""; 
     
    2727        $post_authors[$post->owner] = $author; 
    2828         
    29    
    30     if (!isset($post->authors[$post->weblog])) { 
     29    //
     30    //if (!isset($post->authors[$post->weblog])) { 
    3131        $community = ""; 
    3232         
     
    4343         
    4444        $post_authors[$post->weblog] = $community; 
    45    
     45    //
    4646     
    4747    $date = gmdate("H:i",$post->posted); 
     
    5151     
    5252    // Allow plugins to set special icons 
    53     $specialicon = run("weblogs:posts:geticon",$post->ident); 
     53    $specialicon = run("weblogs:posts:geticon",$post); 
    5454     
    5555    // If there is no special icon for this post, set to the default 
     
    6464     
    6565    // Allow plugins to set the name on the post 
    66     $specialname = run("weblogs:posts:getname",$post->ident); 
    67     if ($specialname == NULL) { 
     66    $specialname = run("weblogs:posts:getname",$post); 
     67    if (empty($specialname)) { 
    6868        $fullname = $post_authors[$post->owner]->fullname; 
    6969    } else {