Changeset 106 for devel/_activity

Timestamp:

01/12/06 08:02:45 (3 years ago)

Author:

sven

Message:

some sql optimisation
- count(*) is more efficient than equivalent count(fieldname) of primary key
- unlefting left joins where the right is required
- "a IN (x,y)" is easier to optimise than "a=x OR a=y"

Files:

• devel/_activity/index.php (modified) (2 diffs)

devel/_activity/index.php

@@ -40 +40 @@
-                
-                $activities = db_query("select users.username, weblog_comments.*, weblog_posts.ident as weblogpost, weblog_posts.title as weblogtitle, weblog_posts.weblog as weblog from weblog_comments left join weblog_posts on weblog_posts.ident = weblog_comments.post_id left join users on users.ident = weblog_posts.weblog where weblog_comments.posted >= $starttime and weblog_posts.owner = $page_owner order by weblog_comments.posted desc");
-
+is_array($activities) && 
-                        foreach($activities as $activity) {
-                                $commentbody = stripslashes($activity->body);
@@ -59 +59 @@
-                
-                $activities = db_query("select users.username, users.name as weblogname, weblog_comments.*, weblog_posts.weblog, weblog_posts.ident as weblogpost, weblog_posts.title as weblogtitle, weblog_posts.weblog as weblog from weblog_watchlist left join weblog_comments on weblog_comments.post_id = weblog_watchlist.weblog_post left join weblog_posts on weblog_posts.ident = weblog_comments.post_id left join users on users.ident = weblog_posts.weblog where weblog_watchlist.owner = $page_owner and weblog_comments.posted >= $starttime order by weblog_comments.posted desc");
-
+is_array($activities) && 
-                        foreach($activities as $activity) {
-                                $commentbody = stripslashes($activity->body);